corpnewt / gibMacOS

Py2/py3 script that can download macOS components direct from Apple
MIT License
5.85k stars 775 forks source link

MakeInstall.bat doesn't show ANY devices #236

Open Otus9051 opened 3 years ago

Otus9051 commented 3 years ago

I am trying to use Clover and use makeinstall.bat for install the OS image to my usb. Problem is nothing shows up. I have also tried manually using makeinstall.py and using administrator privileges (even though it asks for one every time). Nothing happened. I deleted all partitions from my usb, tried replugging it, tried NTFS and Fat32. Nothing shows up. Also I did try the Show All disks option which still didn't do anything,

Otus9051 commented 3 years ago

Commit Number 4083ca20785d96ef26eecac89c1c9e37532beb44 seems more broken as it doesn't even open. FYI I am using Python 3.9

brendoncdrew commented 2 years ago

You ever figure out how to fix this???

I seem to be having the same issue.....

Otus9051 commented 2 years ago

Never.

brendoncdrew commented 2 years ago

Damn

cutie-lyta commented 2 years ago

The reason it is broken, on my end at least, is the removal of wmic.exe on windows 11, and I think later version of 10 It might still work on 8.1 and early 10 version, didn't test tho I am trying to switch to the powershell Get-WMIObject command, but I don't know how to use powershell so I have no luck unfortunately

But at least I know where it's from, if we didn't already

The-Synthax commented 2 years ago

Seems that this is still unusable on Windows 11.

Otus9051 commented 2 years ago

Fixed on mine tho

The-Synthax commented 2 years ago

Fixed on mine tho

Weird. Any idea what fixed it?

Otus9051 commented 2 years ago

nope. no idea. actually, try installing the media feature pack maybe that helped it?

wilkergrcv commented 2 years ago

If you are using an external hard drive instead of a flash drive, change this line in the MakeInstall.py file.

By default it will be like this:

def get_disks_of_type(self, disk_list, disk_type=(0,2)):

with this configuration makeinstall will only show removable and unknown devices

now just change that same line with a 3 looking like this

def get_disks_of_type(self, disk_list, disk_type=(0,2,3)):

save the file and run MakeInstall.bat again and be happy.

RavHilton commented 1 year ago

Same issue here - no drives are shown (Win 11, latest public build, latest public updates, Python 3.11.1, x64) and the addition of disk_type "3" as suggested by https://github.com/wilkergrcv makes no difference at all. Yes, already running elevated as admin...

Even after using option "D", all I see is as follows:

#######################################################

Potential Removable Media #######################################################

!WARNING! This list includes ALL disk types. !WARNING! Be ABSOLUTELY sure before selecting !WARNING! a disk!

Q. Quit

Usage:

KuusamoMart commented 1 year ago

See issue 179 where I have carried out some investigations of the diskwin script and why it doesn't work correctly under Windows 11 and later releases of Windows 10