search

corrados / edrumulus

Open Source E-Drum Trigger Module
GNU General Public License v2.0
97 stars 17 forks source link

merge forward prototype thijstriemstra #114

Closed thijstriemstra closed 10 months ago

thijstriemstra commented 11 months ago

I want to update my prototype to latest version (I was using year old code) so merging it forward. I'm commenting out the customizations I made and starting fresh with new code.

If you see any mistakes in this config, please let me know @corrados

corrados commented 11 months ago

I am using Edrumulus only by using the run_edrumulus script. Therefore, always the edrumulus_gui is used when I use Edrumulus. The advantage of this is that edrumulus_gui takes care of all the settings so that you do not have to modify anything in the preset_settings() function.

If you always use edrumulus_gui as well, the only thing you have to adjust are the analog_pin settings and the number_pads value.

thijstriemstra commented 11 months ago

If you always use edrumulus_gui as well, the only thing you have to adjust are the analog_pin settings and the number_pads value.

Thanks, I'll do that from now on.

corrados commented 10 months ago

I assume that you do not want me to merge your custom prototype branch to main, right? At least it does not make sense for me because it is specific to your prototype and should stay on a branch.

thijstriemstra commented 10 months ago

At least it does not make sense for me because it is specific to your prototype and should stay on a branch.

True, sorry for the confusion, I wanted some feedback on my changes but this was probably wrong way to do it hehe. Thanks for the feedback though!