corrados / edrumulus

Open Source E-Drum Trigger Module
GNU General Public License v2.0
97 stars 17 forks source link

platformio configuration #82

Closed 3hhh closed 1 year ago

3hhh commented 1 year ago

To build all boards, use: pio run

This could even be employed for the CI pipeline.

corrados commented 1 year ago

Thanks. I saw that you had multiple additional changes made. Are you done now or are you still intending to change the files?

3hhh commented 1 year ago

I think it is done now. Thanks for maintaining this project! :-)

corrados commented 1 year ago

@thijstriemstra, since you have created the ".github/workflows/main.yml" file, are you interested in reviewing the changes?

thijstriemstra commented 1 year ago

since you have created the ".github/workflows/main.yml" file, are you interested in reviewing the changes?

sure, no problem.

corrados commented 1 year ago

BTW, I can see in https://github.com/corrados/edrumulus/actions/runs/5846011404/job/15880593278?pr=82 that there are warnings like warning: "MYMIDI" redefined. Is it possible to configure the test that warnings are treated as errors? Then warnings like this are clearly visible by the "failing" badge on the front page.

Another BTW :-), I've no idea right now how to solve that warning...

3hhh commented 1 year ago

These warnings originate from the library dependency finder and are imho not to fix. I even tried with lib_ldf_mode = off, but they are still there.

If you want to stop on all possible gcc (!= LDF) warnings, you can add build_flags = -Werror -Wall to [env] and build_flags = ${env.build_flags} -D USB_MIDI to the Teensy environments. Currently it fails on a bunch of warnings (as -Wall enables all optional warnings) though...

Btw you could probably also install platformio in addition to the Arduino IDE and bind pio run to some hotkey. I usually work that way with vim.

corrados commented 1 year ago

Ok, thanks for the info. I'll merge your changes now. If anything needs to be adjusted later on, just create a new pull request.