correctcomputation / checkedc-clang

This is the primary development repository for 3C, a tool for automatically converting legacy C code to the Checked C extension of C, which aims to enforce spatial memory safety. This repository is a fork of Checked C's.
14 stars 5 forks source link

Update `checkedc-eval*` repos for 3C renaming #312

Closed mattmccutchen-cci closed 3 years ago

mattmccutchen-cci commented 3 years ago

The checkedc-eval* repos probably need some updates in order for the actions to work again after the 3C renaming (#299). Someone who is more familiar with the tangled logic of the actions and benchmark tests than I am should probably take the lead on this, though I am happy to help with anything that doesn't require a lot of knowledge I don't have. Provisionally assigning to @Machiry.

mattmccutchen-cci commented 3 years ago

I think most of us have access to https://github.com/correctcomputation/checkedc-eval now. We decided today that Shilpa is going to work on updating the stuff used by her workflow for the benchmark tests, though we may need help from Aravind to understand the full process of the actions.

mattmccutchen-cci commented 3 years ago

@sroy4899 Umm, what was the outcome here?

sroy4899 commented 3 years ago

Right, sorry, meant to leave a comment but got called away and didn't get a chance to. Turns out none of the repositories need any updating. The actions call the convert_project.py script with the absolute path to 3c, so no renaming or anything is actually needed. With that said, I still did scrounge through the repositories to find any references to cconv-standalone and found a couple in vsftpd. I changed the one instance I found in the baseline branch but the baseline branch is for our own testing purposes, so even if I had left it completely alone, the actions would still be unaffected.

TL;DR: turns out this is a non issue, and updating main.yaml is sufficient for things to work with the renaming.