search

correctexam / corrigeExamFront

Web app to grade your assessments anywhere
https://correctexam.github.io/
MIT License
18 stars 7 forks source link

Changes to comments improperly inserted in the database. #549

Closed nthiery closed 4 months ago

nthiery commented 4 months ago

While grading the other day on this exam I encountered the following incorrect behavior:

  1. In the annotation tab, I imported the default comments in Question 4. These comments then appeared as expected in the UI; but then vanished after leaving the annotation tab. I tried again a couple times without more success. On the other hand, I discovered later that Question 2 had many copies of these comments, presumably from all the attempts. This sounds like an index error while inserting the data in the database.
  2. On several occasions, in the grading tab, I tried to change the percentage associated with a given comment (e.g. for "Erreur de syntaxe"). Again, this was reflected as expected on the UI; but later the change vanished when switching to another question and back. Again, this sounds like the change was not inserted into the database.
barais commented 4 months ago

Thanks, I correct that tomorrow

barais commented 4 months ago

@nthiery Just to be sure on the scenario for the first problem. You saved the comment in json from Q2 and your rimport from JSON in Q4? Right ?

barais commented 4 months ago

@nthiery Found the first bug Forget my question ;)

nthiery commented 4 months ago

Well done :-) Thank you! Feel free to ask for more details if you have trouble reproducing; my report is indeed not as precise as desirable. For confirmation: it was through "sauvegarder commentaires par défaut / ajouter commentaires par défaut".

nthiery commented 4 months ago

Thank your @barais !

barais commented 4 months ago

You're welcome, thanks a lot for the accurate feedback. Two bugs that were hidden only for hybrid comments ;). We have to improve the test suite for hybrid comment.