correij / v8-i18n

Automatically exported from code.google.com/p/v8-i18n
Other
0 stars 0 forks source link

v8Intl.DateTimeFormat returns wrong date #28

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Open a new tab in Google Chrome, Ctrl-Shift-J
2. v8Intl.DateTimeFormat([], {hour: 'numeric'}).format(new Date(0))

What is the expected output? What do you see instead?
hour description for "16"

What version of the product are you using? On what operating system?
returns current time

Please provide any additional information below.
I looked the code, and formatDate() in date-format.js gets 'undefined' for 
'dateValue' argument.  And that's because formatDate is declared by 
addBoundMethod() with length=0, since the parameter is optional.  However, the 
recent patch added the check of the length in addBoundMethod() and changes the 
behavior.

I locally verified that changing the length 0->1 fixes this.

Original issue reported on code.google.com by mukai@chromium.org on 28 Aug 2012 at 9:04

GoogleCodeExporter commented 8 years ago
Issue chromium:143860 has been merged into this issue.

Original comment by mukai@chromium.org on 28 Aug 2012 at 9:06

GoogleCodeExporter commented 8 years ago
It is blocking Issue chromium:144793

Original comment by mukai@chromium.org on 29 Aug 2012 at 4:39

GoogleCodeExporter commented 8 years ago
This bug was fixed recently. I will merge with Chrome today or on Monday.

Original comment by c...@chromium.org on 14 Sep 2012 at 5:12

GoogleCodeExporter commented 8 years ago
cool.  Thanks!

Original comment by mukai@chromium.org on 14 Sep 2012 at 5:22

GoogleCodeExporter commented 8 years ago

Original comment by jshin@chromium.org on 14 Sep 2012 at 10:11

GoogleCodeExporter commented 8 years ago
It's fixed in http://code.google.com/p/v8-i18n/source/detail?r=139 (Sep 7) and 
is being merged to Chromium. 

Original comment by jshin@chromium.org on 14 Sep 2012 at 10:32

GoogleCodeExporter commented 8 years ago

Original comment by c...@google.com on 17 Sep 2012 at 3:54