search

corretto / amazon-corretto-crypto-provider

The Amazon Corretto Crypto Provider is a collection of high-performance cryptographic implementations exposed via standard JCA/JCE interfaces.
Apache License 2.0
238 stars 56 forks source link

Add CI support for old version of gcc #237

Closed samuel40791765 closed 2 years ago

samuel40791765 commented 2 years ago

Issue #, if available: CryptoAlg-1166

Description of changes: Adding support for centos7/gcc4.8 since it's an OS which has an older gcc version and still has support for >= JAVA10. I've tried using the ubuntu7.04 docker image from AWS-LC (https://github.com/awslabs/aws-lc/commit/1e64736db3f709a7e9dd0f016702d42cb29a0902) since it replicates the internal RHEL5 gcc the best, but there are multiple problems with getting a proper version of JAVA working on there. More details can be found under the thread of the SIM.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

samuel40791765 commented 2 years ago

In draft for now since this PR relies on some the new cmake3 behavior in https://github.com/corretto/amazon-corretto-crypto-provider/pull/236

samuel40791765 commented 2 years ago

Replacing this PR with https://github.com/corretto/amazon-corretto-crypto-provider/pull/240