search

corretto / amazon-corretto-crypto-provider

The Amazon Corretto Crypto Provider is a collection of high-performance cryptographic implementations exposed via standard JCA/JCE interfaces.
Apache License 2.0
236 stars 55 forks source link

Add AWS-LC src & ref flags to Gradle build #390

Closed sp717 closed 4 months ago

sp717 commented 4 months ago

Issue #, if available:

Description of changes: In case a user needs to build ACCP with a specific version of AWS-LC, this change adds 2 flags that can be passed to Gradle to specify a source directory for AWS-LC or a specific Git reference.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

geedo0 commented 4 months ago

What's the impetus for this change? Improving developer experience or is this feeding into new CI scripts?

sp717 commented 4 months ago

What's the impetus for this change? Improving developer experience or is this feeding into new CI scripts?

This change helps with updating AWS-LC's CI to include ACCP. The current ACCP build defaults to using v1.30.1 of AWS-LC, but we'd like to test against any new version of AWS-LC, which this update should solve.