search

corretto / corretto-17

Amazon Corretto 17 is a no-cost, multi-platform, production-ready distribution of OpenJDK 17
GNU General Public License v2.0
214 stars 50 forks source link

JDK-11024: [GenShen Preview] Create a special version string for genshen #146

Closed ysramakrishna closed 12 months ago

ysramakrishna commented 1 year ago

This PR is specifically targeted to the generational-shenandoah branch of the corretto-17 project repository.

To distinguish Generational Shenandoah Preview builds from other Corretto-17 builds, they will advertise a special version string:

% ./installers/linux/universal/tar/corretto-build/buildRoot/build/linux-x86_64-server-release/jdk/bin/java -version
openjdk version "17.0.9" 2023-10-17
OpenJDK Runtime Environment Corretto-17.0.9.7.1 (build 17.0.9+7-ExperimentalGenShenPreviewAlpha)
OpenJDK 64-Bit Server VM Corretto-17.0.9.7.1 (build 17.0.9+7-ExperimentalGenShenPreviewAlpha, mixed mode)

Thanks to Dan Lutker and William Kemper for their help with this.

ysramakrishna commented 12 months ago

This approach won't work in the way things are currently set up, per Dan.

I'll close this PR and work on an alternate, more correct approach towards this objective.