search

corretto / corretto-17

Amazon Corretto 17 is a no-cost, multi-platform, production-ready distribution of OpenJDK 17
GNU General Public License v2.0
214 stars 50 forks source link

Alpine build failure #158

Closed elifaslan1 closed 10 months ago

elifaslan1 commented 10 months ago

Description

Addresing Alpine build failure. Whole patch is too large to backport so I am only fixing this line to pass build issue

Related issues

https://bugs.openjdk.org/browse/JDK-8301493

Motivation and context

How has this been tested?

Tested on mac , generic linux and alpine aarch 64

Platform information

Additional context

benty-amzn commented 10 months ago

This looks like a partial backport of https://github.com/openjdk/jdk/commit/948f3b3c24709eca3aa6c3f0db6adb9226d6f9ac#diff-1ff58ce70aeea7e9842d34e8d8fd9c94dd91182999d455618b2a171efd8f742c, is there a reason we're doing this instead of taking the upstream patch?

elifaslan1 commented 10 months ago

I asked maintainer what they can do here:https://bugs.openjdk.org/browse/JDK-8301493

mrserb commented 10 months ago

looks fine as a temporary solution to unblock the build issue.