corretto / corretto-8-docker

Dockerfiles for Amazon Corretto 8
MIT No Attribution
195 stars 40 forks source link

Add JAVA_HOME environment variable #20

Closed mattnelson closed 5 years ago

mattnelson commented 5 years ago

Issue #, if available:

Description of changes:

Add JAVA_HOME environment variable

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

EricEdens commented 5 years ago

Matt, thanks for the PR. I'm queuing up a change that adds container-structure-test to the project. Once that's pushed (hopefully today or tomorrow), can you add a test that verifies your environment variable?

EricEdens commented 5 years ago

All ready! Can you add a test to test-image.yaml then rebase and squash your PR?

mattnelson commented 5 years ago

@EricEdens Added tests. Also enhanced the test runner to work with both supported operating systems (linux/osx).