search

corretto / corretto-8-docker

Dockerfiles for Amazon Corretto 8
MIT No Attribution
195 stars 40 forks source link

switch default locale to utf8 #24

Closed smelchior closed 5 years ago

smelchior commented 5 years ago

Issue: Currently the Image uses POSIX as the default locale, which caused issues for us when switching from the openjdk image. The openjdk image uses C.UTF-8 as the default locale which makes more sense as a sane default.

Description of changes: Switches the default locale to utf-8 for the container

EricEdens commented 5 years ago

Nice! docker-library's #32 provides background on this issue.

Some questions:

@smelchior :

@ilianaw :

smelchior commented 5 years ago

Thanks for the quick response @EricEdens 👍 I did some tests, LANG is sufficient for the JDK, so i removed LC_ALL. A test for the env var has also been added.

iliana commented 5 years ago

Any thoughts on putting this in the AL2 base image instead of here?

Probably not a good idea since we install the glibc-minimal-langpack. wait C.utf-8 is totally a thing in the minimal langpack

I'm not particularly inclined to change our default since the base image has been out for a year? I should discuss it with the team and look at some other base images.

iliana commented 5 years ago

Most other base images don't have any special locales set, so I'll propose that putting it in this image is more correct.

EricEdens commented 5 years ago

Thanks @ilianaw :)

@smelchior, looks good! Go ahead and squash your commits and then I'll merge it.

smelchior commented 5 years ago

sure, squash is done

smelchior commented 5 years ago

nice :) what is the release process for the images on docker hub?

iliana commented 5 years ago

what is the release process for the images on docker hub?

One of the maintainers updates this file and then the Docker Library project's builders build and publish the image.