search

corretto / corretto-8-docker

Dockerfiles for Amazon Corretto 8
MIT No Attribution
195 stars 40 forks source link

Set the correct JAVA_HOME #32

Closed carlossg closed 5 years ago

carlossg commented 5 years ago

Fixes #31

Issue #, if available:

31

Description of changes:

JAVA_HOME points to a non existing dir

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

EricEdens commented 5 years ago

@carlossg : Nice! Can you add a test to make sure that we don't break this in the future? I did one in 8-al2-full branch in https://github.com/corretto/corretto-8-docker/pull/33

carlossg commented 5 years ago

well, there is a problem because the locally built image is different than the on in dockerhub

local:

$ docker run -ti --rm corretto-8 ls -1 /usr/lib/jvm/
java
java-1.8.0-amazon-corretto.x86_64
jre

dockerhub

$ docker run -ti --rm amazoncorretto:8 ls -1 /usr/lib/jvm/
java-1.8.0-amazon-corretto
jre
EricEdens commented 5 years ago

Gosh, I see what happened here: We have a 'master' branch that we don't actually use. The Corretto official image is configured to use the 8-al2-full branch. When I removed the master branch that we're not using, it closed this PR.