search

corretto / corretto-8

Amazon Corretto 8 is a no-cost, multi-platform, production-ready distribution of OpenJDK 8
GNU General Public License v2.0
2.11k stars 221 forks source link

Versioning for Windows is messed up #271

Open mirostauder opened 4 years ago

mirostauder commented 4 years ago

Describe the bug

The advertised version doesn't match the registered/file version some versions become indistinguishable e.g.: advertised version is 8.272.10.3 registered version is 1.8.0.272 affects both x86 and x64 This is confusing and provides false information

To Reproduce

install amazon-corretto-8.272.10.1-windows-x86.msi check Settings -> Apps & Features -> Amazon Corretto shows 1.8.0.272 install amazon-corretto-8.272.10.3-windows-x86.msi check Settings -> Apps & Features -> Amazon Corretto shows same 1.8.0.272

registry for 8.272.10.3 [Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall{981E3643-4A4F-46C0-ABB8-86B81DB482B4}] DisplayVersion=1.8.0.272 respective file versions also show 1.8.0.272

Expected behavior

have a correct version string (8.272.10.3) AT LEAST in DisplayVersion reg key to have a proper version shown in Apps & Features and also 3rd party inventory/update management applications

Screenshots

Screenshot at 2020-10-28 09-53-47

Platform information

OS: Windows Corretto version: 8

Additional context

version 11 behaves correctly in this regard

lutkerd commented 4 years ago

Sorry for the confusion around the versioning. This is consistent with previous releases and changing the DisplayVersion could potentially cause issues for other consumers and package managers. We can reach out to the known the package manager projects and determine if this change would be problematic and address it in a future release.