Closed rgithubli closed 1 year ago
Don't you need to update bin/update-dockerfiles.sh, bin/test-image.sh, bin/tag-generator.py and .github/workflows/verify-images.yml to this as well?
Don't you need to update bin/update-dockerfiles.sh, bin/test-image.sh, bin/tag-generator.py and .github/workflows/verify-images.yml to this as well?
Yes. Didn't know they are in the package. Will do in the next rev.
Edit:
Seems the rest updates are needed, except for bin/test-image.sh
. I can run it by exporting DOCKER_FILE
value and see the Dockerfile being built without any making changes. Don't see past change1 past change2 modified it either.
Hmm broke a flow: https://github.com/corretto/corretto-docker/actions/runs/5743626153/job/15568296604#logs. Will fix in another pr.
Notes
https://github.com/corretto/corretto-docker/issues/164
Providing corretto20 images for AL2023.
Callouts
Corretto 20 doesn't have AL2023 rpm, so we installed generic linux on AL2023. In order to make the basic jdk to be functional, also installed some libs (
fontconfig
,freetype
etc.) However, it's still possible that users need to install required libs if exceptions happen.Had to install gnupg2 (the preinstalled
gnupg2-minimal
doesn't provide import function). However can't uninstall it - the dnf would complainThe operation would result in removing the following protected packages: dnf
. Just leave it there.Tests
Can run a basic HelloWorld in the container