corretto / corretto-docker

Dockerfiles for Amazon Corretto Official images.
https://hub.docker.com/_/amazoncorretto
MIT No Attribution
160 stars 66 forks source link

Adding Corretto-21 images, update github actions #179

Closed mrserb closed 1 year ago

mrserb commented 1 year ago

Description of changes:

Adding Corretto-21 images using the similar approach we did for 17 and 20. The difference from 20 is that we do not have al2023-generic.

lutkerd commented 1 year ago

I don't see changes to bin/apply-template.py or versions.json, were those missed?

benty-amzn commented 1 year ago

I don't see changes to bin/apply-template.py or versions.json, were those missed?

versions.json is there but +1 for the missing script changes

mrserb commented 1 year ago

The work still in progress, the PR is in draft.

mrserb commented 1 year ago

Do I need to update tags manually as well?

lutkerd commented 1 year ago

Do I need to update tags manually as well?

Run the script locally to make sure it worked, the is an GHA to run it after you merge and add the comment on your commit.

mrserb commented 1 year ago

bash bin/update-dockerfiles.sh and python3 bin/tag-generator.py | tee .tags do not produce any errors

lutkerd commented 1 year ago

missing test/test-image-corretto21-jre.yaml to fix the last 2 failures.

mrserb commented 1 year ago

all checks are passed

CasaSky commented 1 year ago

can i access to the docker image of corretto 21? docker pull amazoncorretto:21 fails with Error response from daemon: manifest for amazoncorretto:21 not found: manifest unknown: manifest unknown

SentryMan commented 1 year ago

can i access to the docker image of corretto 21? docker pull amazoncorretto:21 fails with Error response from daemon: manifest for amazoncorretto:21 not found: manifest unknown: manifest unknown

I'm also getting this

fbellomi commented 1 year ago

can i access to the docker image of corretto 21? docker pull amazoncorretto:21 fails with Error response from daemon: manifest for amazoncorretto:21 not found: manifest unknown: manifest unknown

I'm also getting this

+1

benty-amzn commented 1 year ago

The corretto 21 images have not been published to official-images/amazoncorretto yet. We expect them to be available soon and we'll post an update here when they're ready.

benty-amzn commented 1 year ago

official-images#15408 is the PR for the update. Once that's merged images should be available on dockerhub and ecr gallery within a few hours.