search

corretto / corretto-docker

Dockerfiles for Amazon Corretto Official images.
https://hub.docker.com/_/amazoncorretto
MIT No Attribution
152 stars 63 forks source link

Add dockerfiles for alpine 3.15 #85

Closed cliveverghese closed 2 years ago

cliveverghese commented 2 years ago

Issue #, if available:

Add Dockerfiles for alpine3.15.

Addresses #76

github-actions[bot] commented 2 years ago

Diff for cb2e8df563cd9f9ceadf8a6f156152ab481a9ad0:

The repository contains the expected content

updated tags for [library/amazoncorretto](https://github.com/docker-library/official-images/blob/master/library/amazoncorretto) 
Tags: 8, 8u312, 8u312-al2, 8-al2-full, 8-al2-jdk, latest
Architectures: amd64, arm64v8
Directory: 8/jdk/al2

Tags: 8-alpine3.12, 8u312-alpine3.12, 8-alpine3.12-full, 8-alpine3.12-jdk
Architectures: amd64
Directory: 8/jdk/alpine/3.12

Tags: 8-alpine3.12-jre, 8u312-alpine3.12-jre
Architectures: amd64
Directory: 8/jre/alpine/3.12

Tags: 8-alpine3.13, 8u312-alpine3.13, 8-alpine3.13-full, 8-alpine3.13-jdk
Architectures: amd64
Directory: 8/jdk/alpine/3.13

Tags: 8-alpine3.13-jre, 8u312-alpine3.13-jre
Architectures: amd64
Directory: 8/jre/alpine/3.13

Tags: 8-alpine3.14, 8u312-alpine3.14, 8-alpine3.14-full, 8-alpine3.14-jdk
Architectures: amd64
Directory: 8/jdk/alpine/3.14

Tags: 8-alpine3.14-jre, 8u312-alpine3.14-jre
Architectures: amd64
Directory: 8/jre/alpine/3.14

Tags: 8-alpine3.15, 8u312-alpine3.15, 8-alpine3.15-full, 8-alpine3.15-jdk, 8-alpine, 8u312-alpine, 8-alpine-full, 8-alpine-jdk
Architectures: amd64
Directory: 8/jdk/alpine/3.15

Tags: 8-alpine3.15-jre, 8u312-alpine3.15-jre, 8-alpine-jre, 8u312-alpine-jre
Architectures: amd64
Directory: 8/jre/alpine/3.15

Tags: 11, 11.0.13, 11.0.13-al2, 11-al2-full, 11-al2-jdk
Architectures: amd64, arm64v8
Directory: 11/jdk/al2

Tags: 11-alpine3.12, 11.0.13-alpine3.12, 11-alpine3.12-full, 11-alpine3.12-jdk
Architectures: amd64
Directory: 11/jdk/alpine/3.12

Tags: 11-alpine3.13, 11.0.13-alpine3.13, 11-alpine3.13-full, 11-alpine3.13-jdk
Architectures: amd64
Directory: 11/jdk/alpine/3.13

Tags: 11-alpine3.14, 11.0.13-alpine3.14, 11-alpine3.14-full, 11-alpine3.14-jdk
Architectures: amd64
Directory: 11/jdk/alpine/3.14

Tags: 11-alpine3.15, 11.0.13-alpine3.15, 11-alpine3.15-full, 11-alpine3.15-jdk, 11-alpine, 11.0.13-alpine, 11-alpine-full, 11-alpine-jdk
Architectures: amd64
Directory: 11/jdk/alpine/3.15

Tags: 17, 17.0.1, 17.0.1-al2, 17-al2-full, 17-al2-jdk
Architectures: amd64, arm64v8
Directory: 17/jdk/al2

Tags: 17-alpine3.12, 17.0.1-alpine3.12, 17-alpine3.12-full, 17-alpine3.12-jdk
Architectures: amd64
Directory: 17/jdk/alpine/3.12

Tags: 17-alpine3.13, 17.0.1-alpine3.13, 17-alpine3.13-full, 17-alpine3.13-jdk
Architectures: amd64
Directory: 17/jdk/alpine/3.13

Tags: 17-alpine3.14, 17.0.1-alpine3.14, 17-alpine3.14-full, 17-alpine3.14-jdk
Architectures: amd64
Directory: 17/jdk/alpine/3.14

Tags: 17-alpine3.15, 17.0.1-alpine3.15, 17-alpine3.15-full, 17-alpine3.15-jdk, 17-alpine, 17.0.1-alpine, 17-alpine-full, 17-alpine-jdk
Architectures: amd64
Directory: 17/jdk/alpine/3.15

JohnPreston commented 2 years ago

Can I enquire why you guys are using dockerhub capabilities over what you could do by using CodeBuild / GH Actions ? Clearly public ECR is gaining in popularity and I am not sure why you guys would not showcase the AWS Services capabilities at the same time? (From previous PR convo anyway).

cliveverghese commented 2 years ago

Can I enquire why you guys are using dockerhub capabilities over what you could do by using CodeBuild / GH Actions ?

We still receive a significant number of pulls from Dockerhub for amazoncorretto image as the easiest command docker pull amazoncorretto retrieves the images from this location.

Clearly public ECR is gaining in popularity and I am not sure why you guys would not showcase the AWS Services capabilities at the same time? (From previous PR convo anyway).

The images will be available it ECR as well at amazoncorretto and docker

JohnPreston commented 2 years ago

We still receive a significant number of pulls from Dockerhub for amazoncorretto image as the easiest command docker pull amazoncorretto retrieves the images from this location.

I suppose my point is, you could still push to dockerhub without buidling on dockerhub.

This would allow for a much nicer way IMHO than rely on dockerhub. Alpine is version 3.15, grows quickly. Are you going to have a subfolder for every single alpine version just because dockerhub does not support an ARG to override the version? /shrug

lutkerd commented 2 years ago

When Alpine updates 3.15, they will have tags for both 3.15.1 and 3.15 to point to the same image. At least that is what they have done for the previous releases. Dockerhub will automatically rebuild our alpine based images for us without us needing to build and maintain infrastructure to query all of the base images, run workflows and push new images.

As an "Official Image" I don't think we have the ability to push a new image and it must be built by Dockerhub from the commit in https://github.com/docker-library/official-images/blob/master/library/amazoncorretto