corrosion-rs / corrosion

Marrying Rust and CMake - Easy Rust and C/C++ Integration!
https://corrosion-rs.github.io/corrosion/
MIT License
1.02k stars 97 forks source link

corrosion_import_crate: Fix PROFILE argument in combination with CRATES #496

Closed Felix-El closed 3 months ago

Felix-El commented 3 months ago

Do not forward the PROFILE argument from corrosion_import_crate to _generator_add_cargo_targets.

Closes #495.

jschwe commented 3 months ago

Thanks for the PR! Yes, it's a leftover from 411a7f37abf3cdc7941c70ff166a06aef19cacd3, where the PROFILE argument was changed to be set via target property and not propagated down the call-chain anymore.