backport: Fix PROFILE argument in combination with CRATES

corrosion-rs / corrosion

Marrying Rust and CMake - Easy Rust and C/C++ Integration!

https://corrosion-rs.github.io/corrosion/

MIT License

1.07k stars 103 forks source link

backport: Fix PROFILE argument in combination with CRATES #498

Closed jschwe closed 6 months ago

jschwe commented 6 months ago

Do not forward the PROFILE argument from corrosion_import_crate to _generator_add_cargo_targets. The PROFILE argument is forwarded via a target property set during corrosion_import_crate. The remaining argument forwarding can cause issues when combined with a multi-value-argument, such as CRATES.

(cherry picked from commit d5bdbfacb4d2c013f7bebabc6c95a118dc1e9fe1)

jschwe commented 6 months ago

The failure on nightly is a change in cargo-metadata output on nightly rust, and not related to corrosions stable branch or this change.