search

corrosion-rs / corrosion

Marrying Rust and CMake - Easy Rust and C/C++ Integration!
https://corrosion-rs.github.io/corrosion/
MIT License
1.1k stars 106 forks source link

Make corrosion_install work for library files and update docs #543

Closed gtker closed 3 months ago

gtker commented 3 months ago

Works on #415 and #63.

This only installs the actual library file(s) and not extras such as headers.

Not tested on Windows for compatibility with import library files for shared libraries.

I moved the function definition out to be used as an anchor so it could be used for docs without modifying it, since I'm not entirely sure what the planned feature set of it is going to be.

gtker commented 3 months ago

Not sure if I have broken the MacOS tests, but it seems unrelated.

jschwe commented 3 months ago

The test failures on macos are unrelated to this PR.

gtker commented 3 months ago

@jschwe Do you need anything else from me on this PR?

gtker commented 3 months ago

There is still one todo in the documentation that should be addressed before merging.

Fixed.

If I have some time next week, I'll try to add a test.

Cool. The https://github.com/gtker/corrosion_export repo can be used with the functionality that is now done in corrosion_install removed.