Refactor daemon_client.

corso-python-prato / share-system-team2

Apache License 2.0

2 stars 9 forks source link

Refactor daemon_client. #88

Closed k4rl85 closed 9 years ago

k4rl85 commented 9 years ago

New file called utils created to contain the tools used by Daemon.
The methods relative creation and load cfg are rewriten
Now sharing_path and local_dir_state aren't inside cfg, they depend from cfg_dir and sharing_dir received from argparse (default value aren't change)
SkipObserver moved in utils
Many methods inside daemon now are trasnformed in function inside utils file.
Some improves in loggin implemantation.

coveralls commented 9 years ago

Coverage decreased (-0.59%) when pulling 975a9e98d84e3831383cc68a225c11521c873de3 on k4rl85:improves_config into bfb4bb278ad4fa8491e173dd6a2ae8ef50ea9fa3 on corso-python-prato:master.

coveralls commented 9 years ago

Coverage decreased (-0.59%) when pulling 42f2eccfc0feb5aab4d5e3169a7923e791d9b4bc on k4rl85:improves_config into bfb4bb278ad4fa8491e173dd6a2ae8ef50ea9fa3 on corso-python-prato:master.

GendoIkari commented 9 years ago

Non mi torna assolutamente che tu abbia spostato una serie di cose eterogenee in una class come DaemonUtils solo per far dimagrire un po' il daemon. Se volevi scorporare un po' di logica dal daemon (bene) magari e' piu' logico aggredire altre parti, come lo snapshot. Mi aspetterei anche una api del tipo:

self.snap = Snapshot("/home/user/....")
snap1 = Snapshot.fromJson(server_snap)
sync_commands = self.snap.sync(snap1, ..., ...)

Questo secondo me sarebbe un refactoring piu' sensato.