search

cortesi / modd

A flexible developer tool that runs processes and responds to filesystem changes
MIT License
2.8k stars 128 forks source link

Fix the runtime.sigpanic() bug #107

Closed joncalhoun closed 2 years ago

joncalhoun commented 2 years ago

This package uses cortesi/termlog which uses fatih/color v1.10.0. I believe color v1.10.0 is causing the panic when testing and building, but moving to v1.13.0 fixes this. Another option might be to update cortesi/termlog and then update the version of that library used here in modd, but this fix is a bit simpler for now since it is a single commit.

TL;DR - this seems to fix the build on my end and allows people to continue installing and using modd.

cortesi commented 2 years ago

Jon, this LGTM. I'm a bit distracted by some personal matters at the moment, so modd is languishing a bit. Can I add you as a maintainer to the project, on the strict understanding that that I don't expect you to spend any more time or take any more responsibility for the project than you are comfortable with?

joncalhoun commented 2 years ago

Hi - happy to try to help. I suspect, like you, I won't have a bunch of time to add new features, but I'm willing to try to help get things working with go modules and 1.17 so others can benefit from this project.

cortesi commented 2 years ago

Much appreciated, Jon. I'll add you to the related projects as well.

frederikhors commented 2 years ago

I am glad that more people have noticed how useful this project is. Is the best.

Happy to contribute as soon as possible.

Thanks for your commitment.