search

cortesi / modd

A flexible developer tool that runs processes and responds to filesystem changes
MIT License
2.78k stars 130 forks source link

Error: modd has been disabled because it is not maintained upstream! #119

Open karolvargas opened 1 year ago

karolvargas commented 1 year ago

Currently on an i7 with Mac OS 12.6 installed and getting this error when attempting to install modd with brew for the first time

Running brew update --auto-update...
==> Auto-updated Homebrew!
Updated 1 tap (homebrew/core).

You have 21 outdated formulae and 2 outdated casks installed.
You can upgrade them with brew upgrade
or list them with brew outdated.

Error: modd has been disabled because it is not maintained upstream!
simjak commented 1 year ago

Use go install github.com/cortesi/modd/cmd/modd@latest

jesselang commented 1 year ago

Using go install does not work for me.

% go install github.com/cortesi/modd/cmd/modd@latest
# github.com/rjeczalik/notify
../../dev/go/pkg/mod/github.com/rjeczalik/notify@v0.0.0-20181126183243-629144ba06a1/watcher_fsevents.go:49:11: undefined: stream
../../dev/go/pkg/mod/github.com/rjeczalik/notify@v0.0.0-20181126183243-629144ba06a1/watcher_fsevents.go:200:13: undefined: newStream
joncalhoun commented 1 year ago

What version of Go are you running?

Can you try cleaning your caches, and then installing?

go clean -modcache
go clean -cache
jesselang commented 1 year ago

Thanks for the suggestion, but it doesn't seem to make a difference. I'd be happy to open a separate issue if desired.

%  go version
go version go1.18 darwin/amd64

% go clean -modcache
% go clean -cache

% go install github.com/cortesi/modd/cmd/modd@latest
go: downloading github.com/cortesi/modd v0.0.0-20221227201034-99fec65d0ecf
go: downloading github.com/cortesi/termlog v0.0.0-20210222042314-a1eec763abec
go: downloading mvdan.cc/sh/v3 v3.3.0-0.dev.0.20210224101809-fb5052e7a010
go: downloading gopkg.in/alecthomas/kingpin.v2 v2.2.6
go: downloading github.com/cortesi/moddwatch v0.0.0-20210222043437-a6aaad86a36e
go: downloading github.com/alecthomas/units v0.0.0-20210208195552-ff826a37aa15
go: downloading github.com/alecthomas/template v0.0.0-20190718012654-fb15b899a751
go: downloading github.com/rjeczalik/notify v0.0.0-20181126183243-629144ba06a1
go: downloading github.com/bmatcuk/doublestar v1.3.4
go: downloading golang.org/x/sync v0.0.0-20210220032951-036812b2e83c
go: downloading golang.org/x/sys v0.0.0-20210630005230-0f9fa26af87c
go: downloading golang.org/x/term v0.0.0-20210317153231-de623e64d2a6
go: downloading golang.org/x/net v0.0.0-20210323141857-08027d57d8cf
go: downloading github.com/fatih/color v1.13.0
go: downloading golang.org/x/crypto v0.0.0-20210322153248-0c34fe9e7dc2
go: downloading github.com/mattn/go-colorable v0.1.9
go: downloading github.com/mattn/go-isatty v0.0.14
# github.com/rjeczalik/notify
dev/go/pkg/mod/github.com/rjeczalik/notify@v0.0.0-20181126183243-629144ba06a1/watcher_fsevents.go:49:11: undefined: stream
dev/go/pkg/mod/github.com/rjeczalik/notify@v0.0.0-20181126183243-629144ba06a1/watcher_fsevents.go:200:13: undefined: newStream
jesselang commented 1 year ago

Ah, CGO_ENABLED must be enabled. I have it set to zero by default. This worked.

CGO_ENABLED=1 go install github.com/cortesi/modd/cmd/modd@latest
jesselang commented 1 year ago

It appears the brew formulae for modd was disabled on September 14th, 2022 after being deprecated on August 27th, 2021. https://github.com/Homebrew/homebrew-core/pull/84056 offers meaningful context (referencing #96) which points to the need for a release which uses Go modules. Presumably, once that new release exists, the formulae can be revived from its disabled state. I've updated dependencies in #123 in preparation for a new release. I hope this helps. Thanks!

jesselang commented 1 year ago

@joncalhoun, I'd be interested in your review of my findings, and perhaps we could work together toward a resolution? Thanks much!

joncalhoun commented 1 year ago

Sorry. Go ahead and start prepping things for a go modules release if you think that will help resolve the brew issue. Would be a good idea to have a go module version here anyway.

jesselang commented 1 year ago

@joncalhoun, with #123 merged, I believe the next step would be to create a new release. After which, the homebrew formula could be updated to use that new release. Thoughts?

uvulpos commented 1 year ago

✅ SOLVED: MacOS M1 cannot install app

I think I tried now every possible solution and nothing worked. Just to summaries everything: brew is disabled, the go get / go install command runs without issue but the command modd is unregistered and the MacOS Binary from the release section is not signed, so it is not executable.

Screenshot 2023-05-17 at 02 08 00
joncalhoun commented 1 year ago

I'm running modd on an M2, so it is definitely possible. I don't recall what I had to do to make it work though (if anything).

You may need to update your security & privacy settings to open apps from identified developers, then make an exception for modd. I don't recall if I did that or not.

Another thing to possibly check is which version of modd is being run and ensure it isn't a leftover file (vs the one go install creates). Maybe run which modd and delete/move the files until you get no binary (in case multiple are installed), then do a fresh go install?

On Tue, May 16, 2023 at 8:12 PM Tim Riedl @.***> wrote:

MacOS M1 cannot install app

I think I tried now every possible solution and nothing worked. Just to summaries everything: brew is disabled, the go get / go install command runs without issue but the command modd is unregistered and the MacOS Binary from the release section is not signed, so it is not executable. [image: Screenshot 2023-05-17 at 02 08 00] https://user-images.githubusercontent.com/53957681/238798152-56969147-b12f-4496-9f0e-161d42fd2bd3.png

— Reply to this email directly, view it on GitHub https://github.com/cortesi/modd/issues/119#issuecomment-1550511033, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMZT6LAFUOOLNNCG4SFQPTXGQJYTANCNFSM6AAAAAAQ7V6UWQ . You are receiving this because you were mentioned.Message ID: @.***>

uvulpos commented 1 year ago

I discovered that my golang installation does install it but does not register it as a command. At first I registered it in the bashrc config because I was told you cannot register commands on macos, but then I read you can do that by creating a link to /usr/local/bin/<command-name>so issue solved

silverwind commented 3 months ago

go install method works fine and that homebrew formula seems to have been some inofficial thing, so I recommend closing the issue.