Closed sunfmin closed 5 years ago
I'm getting the same error on go 1.10.4.
$ go version
go version go1.10.4 darwin/amd64
go get -v github.com/coresi/modd/cmd/modd
github.com/coresi/modd (download)
.
.
.
# github.com/cortesi/modd/vendor/github.com/rjeczalik/notify
../../../go/src/github.com/cortesi/modd/vendor/github.com/rjeczalik/notify/watcher_fsevents_cgo.go:51: cannot use nil as type _Ctype_CFAllocatorRef in argument to func literal
../../../go/src/github.com/cortesi/modd/vendor/github.com/rjeczalik/notify/watcher_fsevents_cgo.go:169: cannot use nil as type _Ctype_CFAllocatorRef in argument to _Cfunc_CFStringCreateWithCStringNoCopy
../../../go/src/github.com/cortesi/modd/vendor/github.com/rjeczalik/notify/watcher_fsevents_cgo.go:170: cannot use nil as type _Ctype_CFAllocatorRef in argument to func literal
I believe I have gotten to the bottom of this issue. modd
is using an out-of-date version of https://github.com/rjeczalik/notify which is causing our builds to fail. This is also affecting devd
.
I have created a more detailed write-up here: https://github.com/cortesi/devd/issues/94
I'm curious if this issue is happening for Mac OS X users or for everyone. @sunfmin @deltam @jackwilsdon what platform are ya'll trying to build on?
I'm on Mac OS X High Sierra.
I'm also on macOS High Sierra.
I'm on macOS High Sierre.
Apologies for taking a while to get to this. This issue has been fixed in a recent dependency update.
Hi. Homebrew maintainer here. I stumbled over that problem today, see https://github.com/Homebrew/homebrew-core/pull/36194 (the changes are slightly unrelated but the CI rebuilt the package and failed to do so).
Is there a patch which we could use to fix the broken modd
build? Any related commits we could cherry-pick? Or could you cut a new release with the fix? Thanks!
@iMichka Hi there! I've just released modd v0.8, which includes the dependency update that contains this fix. Thanks for pinging me about this.
Go version