Closed mwtoews closed 2 years ago
Merging #534 (2c0da74) into master (964a0b3) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #534 +/- ##
=======================================
Coverage 96.22% 96.22%
=======================================
Files 13 13
Lines 1591 1591
=======================================
Hits 1531 1531
Misses 60 60
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update 964a0b3...2c0da74. Read the comment docs.
I'll assume that "Test latest dependencies" is unrelated. Merge #536 before this one, and I'll merge it here too to get the build test.
Looks great π. Did you want to squash your commits or do you mind if I do it on merge?
Yes, squash with title-only is good, as a xref to the PR is sufficient. Thanks!
Thanks @mwtoews π
This PR is very similar to https://github.com/corteva/geocube/pull/111
setup.cfg
:bdist_universal
optionlicense_files
to side-step warning inpython -m build
long_description_content_type
to side-step warning intwine check dist/*
setup.py
is now a basic shim file, and does nothing custom; it might be removed at some pointpytest
command instead ofpy.test
(ref)make dist
target, which was referenced in the Makefiletwine check --strict dist/*
before uploading release -- also.whl
files could and should be uploaded to PyPI