corteva / rioxarray

geospatial xarray extension powered by rasterio
https://corteva.github.io/rioxarray
Other
507 stars 80 forks source link

BUG: pass warp_extras to rasterio.vrt.WarpedVRT #599

Closed scottyhq closed 1 year ago

scottyhq commented 1 year ago
codecov[bot] commented 1 year ago

Codecov Report

Base: 96.16% // Head: 96.16% // No change to project coverage :thumbsup:

Coverage data is based on head (a755cdf) compared to base (041e6bd). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #599 +/- ## ======================================= Coverage 96.16% 96.16% ======================================= Files 11 11 Lines 1641 1641 ======================================= Hits 1578 1578 Misses 63 63 ``` | [Impacted Files](https://codecov.io/gh/corteva/rioxarray/pull/599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=corteva) | Coverage Δ | | |---|---|---| | [rioxarray/\_io.py](https://codecov.io/gh/corteva/rioxarray/pull/599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=corteva#diff-cmlveGFycmF5L19pby5weQ==) | `95.83% <ø> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=corteva). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=corteva)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

snowman2 commented 1 year ago

I am wondering if you need to update the test to work like this: https://github.com/corteva/rioxarray/issues/339#issuecomment-853877629

snowman2 commented 1 year ago

Warp options needs rasterio 1.3+ ref. Adding this to the test should address the failures:

@pytest.mark.skipif(
    not RASTERIO_GE_13,
    reason="warp options support added in 1.3.0",
)
snowman2 commented 1 year ago

Thanks @scottyhq :+1: