search

corteva / rioxarray

geospatial xarray extension powered by rasterio
https://corteva.github.io/rioxarray
Other
507 stars 80 forks source link

TYPE: Use explicit optional #604

Closed snowman2 closed 1 year ago

snowman2 commented 1 year ago 
note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True

https://peps.python.org/pep-0484/

Type checkers should move towards requiring the optional type to be made explicit.

codecov[bot] commented 1 year ago

Codecov Report

Base: 96.33% // Head: 96.33% // No change to project coverage :thumbsup:

Coverage data is based on head (651b6a4) compared to base (9643b46). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #604 +/- ## ======================================= Coverage 96.33% 96.33% ======================================= Files 11 11 Lines 1691 1691 ======================================= Hits 1629 1629 Misses 62 62 ``` | [Impacted Files](https://codecov.io/gh/corteva/rioxarray/pull/604?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=corteva) | Coverage Δ | | |---|---|---| | [rioxarray/\_io.py](https://codecov.io/gh/corteva/rioxarray/pull/604/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=corteva#diff-cmlveGFycmF5L19pby5weQ==) | `96.44% <ø> (ø)` | | | [rioxarray/raster\_array.py](https://codecov.io/gh/corteva/rioxarray/pull/604/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=corteva#diff-cmlveGFycmF5L3Jhc3Rlcl9hcnJheS5weQ==) | `97.79% <ø> (ø)` | | | [rioxarray/raster\_dataset.py](https://codecov.io/gh/corteva/rioxarray/pull/604/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=corteva#diff-cmlveGFycmF5L3Jhc3Rlcl9kYXRhc2V0LnB5) | `100.00% <ø> (ø)` | | | [rioxarray/rioxarray.py](https://codecov.io/gh/corteva/rioxarray/pull/604/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=corteva#diff-cmlveGFycmF5L3Jpb3hhcnJheS5weQ==) | `96.60% <ø> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=corteva). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=corteva)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.