Closed caldwellst closed 1 year ago
Base: 96.02% // Head: 95.90% // Decreases project coverage by -0.11%
:warning:
Coverage data is based on head (
fffee84
) compared to base (0f77e13
). Patch has no changes to coverable lines.:exclamation: Current head fffee84 differs from pull request most recent head dabc42b. Consider uploading reports for the commit dabc42b to get more accurate results
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
One option to make this more future proof is to change this: https://github.com/corteva/rioxarray/blob/0f77e13b54ba82ffb9cf2f655c9e310f85890bd9/rioxarray/raster_array.py#L513
to:
_NODATA_DTYPE_MAP.get(dtype_rev[self._obj.dtype.name])
Thoughts?
I think that sounds like a solid idea, particularly as it seems unlikely new data types will be added with corresponding defaults. It may be useful to just set a reminder to check in a set period of time (1 year) if that list has changed in case standard defaults have been added for those that are None
.
I think that sounds like a solid idea
Mind updating this PR with the change?
Thanks @caldwellst :+1:
docs/history.rst
and edited hyperlink comment inrioxarray/raster_array.py