search

cortex-js / compute-engine

An engine for symbolic manipulation and numeric evaluation of math formulas expressed with MathJSON
https://cortexjs.io
MIT License
356 stars 42 forks source link

["Or", "False", "False"] = true #166

Closed Frizzled closed 2 months ago

Frizzled commented 3 months ago

Engine evaluates:

["Or", "False", "False"]

as true

Screen Shot 2024-05-24 at 8 15 59 PM
arnog commented 3 months ago

Dupe of #73

Frizzled commented 3 months ago

73 was not fixed (even though it is closed as fixed); this issue exists in

the most recent version.

On Fri, May 24, 2024, 11:51 PM Arno Gourdol @.***> wrote:

Dupe of #73 https://github.com/cortex-js/compute-engine/issues/73

— Reply to this email directly, view it on GitHub https://github.com/cortex-js/compute-engine/issues/166#issuecomment-2130735211, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIQEVOB6D7Z6EQEP74HFO3ZEADDPAVCNFSM6AAAAABIIMLXY6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZQG4ZTKMRRGE . You are receiving this because you authored the thread.Message ID: @.***>

arnog commented 3 months ago

The fix is here: https://github.com/cortex-js/compute-engine/commit/be8dffedd983bd7a37589d2b16a1da4c24f00791

Issues get closed when the fix is in the repo. A build with this fix has not been published yet.