cortex-lab / KiloSort

GPU code for spike sorting
GNU General Public License v2.0
177 stars 100 forks source link

organisation of functions in repository #79

Closed zeeMonkeez closed 7 years ago

zeeMonkeez commented 7 years ago

Currently, the Kilosort repository pollutes the MATLAB path with many function definitions, some of which are rather generic (such as shift_data) or even conflict with MATLAB internal functions (normc) and are presumably not meant to be used by end users directly. Would it be possible to make functions that are not intended to be publicly accessible private? As a consequence, instead of having to add the whole tree to MATLAB's path, only the root folder would have to be added, decluttering the PATH configuration.

marius10p commented 7 years ago

If you offer a better solution I can look into it, but dumping all functions into a folder called "private" is not an option. The simple solution is to not add Kilosort to your path at startup. Just add it at the top of your master_file script, and then it won't pollute your path on a non-Kilosort session.

P.S. "normc" is inside a toolbox, and we did not want to require that toolbox.