cortex-lab / PinkRigs

Shared code for processing data on the pink rigs
3 stars 1 forks source link

Inconsistencies in syntax between Matlab and Python with argument 'lastX' #39

Closed cbimbo closed 1 year ago

cbimbo commented 1 year ago

When specifying which dates to load or process with argument 'lastX', the interpretation is different between Matlab and Python. In Matlab, it is the last X experiments (whatever their dates, e.g., in csv.queryExp) and in Python, it is the last X days (e.g., in check_date_selection**).

** btw, this function should be externalized, since it is now duplicated in the IBL format conversion script and the pyKS script.

takacsflora commented 1 year ago

function is externalised.

takacsflora commented 1 year ago

python 'lastX' now matches the meaning of the matlab syntax. (last x days compared to today can also be called with the syntax 'previousXdays')