cortex-lab / Rigbox

A MATLAB toolbox for running behavioral neuroscience experiments and managing data
GNU General Public License v3.0
33 stars 16 forks source link

setEpochTrigger method doesn't work #281

Closed k1o0 closed 3 years ago

k1o0 commented 4 years ago

Describe the bug setEpochTrigger method doesn't work

To Reproduce

[x, y, t] = sig.create;
qevt = setEpochTrigger(x, t, y, 5);

Unrecognized method, property, or field 'armed' for class 'sig.node.SubscriptableSignal'.

Error in sig.node.Signal/setEpochTrigger (line 486)
      qevt = state.armed.skipRepeats().not().then(true);

Expected behavior This shouldn't throw an error, there should be a test to validate this.

Additional context This should have not entered the code without a test.

k1o0 commented 4 years ago

https://github.com/cortex-lab/signals/commit/7720160add8aec1b5f56bb8bf8bcb82d69f2de56