search

cortex-lab / Suite2P

Tools for processing 2P recordings
Other
121 stars 66 forks source link

Missing Fbase when L1 option is chosen #126

Closed bradmonk closed 6 years ago

bradmonk commented 6 years ago

In wrapperDECONV when you choose the OASIS option, the OASISpreprocess() function returns a variable called Fbase, but when you choose the L1 option the function does establish this variable. Several lines later Fbase is a required input for a bsxfun call, and thus results in an error when using the L1 option...

switch getOr(ops, 'deconvType', 'OASIS')
    case 'OASIS'
        [sp, ca, sd2, Fbase] = OASISpreprocess(ops,  Fsub);
    case 'L0'
        [sp, ca, sd2] = deconvolution_standalone(ops, Fsub);
end

baselines = bsxfun(@times, mean(Fbase,1), sd); :warning:

https://github.com/cortex-lab/Suite2P/blob/2d2b3e4663b55bc4ec611fee67f399d6802a7638/SpikeDetection/wrapperDECONV.m#L94

marius10p commented 6 years ago

Sorry, I broke that temporarily with an update but it should be working now.

carsen-stringer commented 6 years ago

please reopen if there are still issues with this, thanks