search

cortex-lab / Suite2P

Tools for processing 2P recordings
Other
121 stars 66 forks source link

Potential bug in openBinFiles #131

Closed fralik closed 5 years ago

fralik commented 6 years ago

Seems like a potential bug to me in file openBinFiles on line 9. Variable xFOVs is not defined in that function and it is not a function itself.

carsen-stringer commented 6 years ago

Oops thanks for that. Are you trying to run with interpolation across planes? What that means is the registration aligns the mean images across planes in Z. xFOVs is used to split up the FOV into multiple sections, sorry I've never tested these options together (we don't use the interpolation ourselves) and missed this. What kind of data are you trying to process? Maybe I can help you with the settings?

fralik commented 6 years ago

Not really. I am working on a version of Suite2P that decouples the file structure from the code, i.e. so it is possible to have different storage schemas. Would like to make it backwards compatible, so that you could perhaps merge it into the main source code. For that, I am going through Suite2P and trying to understand it.

carsen-stringer commented 6 years ago

Awesome! That sounds really useful. Right now the code is messiest in the registration because there are many different options, in particular to run with multi-plane imaging, which may not be necessary for all users.

carsen-stringer commented 5 years ago

We've added an option in the python version to run a user-specified clean-up script at the end of the pipeline. You could use this script to for instance copy binary files to certain locations that you want, which might address what you're trying to do