Open synapticlee opened 5 years ago
Hi, not sure if this matters (or if this was intentional) but I noticed in the code for deconvolution using OASIS, when OASISpreprocess is called here: https://github.com/cortex-lab/Suite2P/blob/2d2b3e4663b55bc4ec611fee67f399d6802a7638/SpikeDetection/wrapperDECONV.m#L65
it returns "Fbase" as its fourth output, yet the fourth output of OASISpreprocess is actually "F1", which is the calcium subtracted by the baseline, Fbase.
Thanks for catching that bug. I am not sure when we introduced it, but we never really use the baselines so we never noticed.
Hi, not sure if this matters (or if this was intentional) but I noticed in the code for deconvolution using OASIS, when OASISpreprocess is called here: https://github.com/cortex-lab/Suite2P/blob/2d2b3e4663b55bc4ec611fee67f399d6802a7638/SpikeDetection/wrapperDECONV.m#L65
it returns "Fbase" as its fourth output, yet the fourth output of OASISpreprocess is actually "F1", which is the calcium subtracted by the baseline, Fbase.