Open sylviaschroeder opened 5 years ago
Sorry but can you please double check it works with targetImage empty too? It looks good but I'd rather play it safe because that's the setting most people will use.
I tested the code now for use with targetImage empty. It works as expected.
I am going to pull this in... if it breaks something, someone say something?
Dear colleagues, I just installed and troubleshot the beginning with the matlab version of suite2p. I don't know where to write, but I think I identified a bug in build_ops3.m On line 31 it says ffile = dir(fullfile(ops.RootDir, ops.SubDirs{j}, '.tif')); I think that there should be square brackets in the fullfile function. ffile = dir([fullfile(ops.RootDir, ops.SubDirs{j}, '.tif')]);
This was what helped me to go through the pipeline.
I would also like to express the deepest gratitude for your software package. It is awesome!
Thanks! @xigumalu can you please check this and if it's right I can merge the pull request.
when using a specific experiment to get target image (targetImage not empty)
This is resolving issue #166
I tested the new code when targetImage is not empty. Please, have a look for when targetImage is empty. However, I based the new code primarily on the old code that existed for the case when targetImage is empty.