re-order the constructor so that dat.paths URL is used

cortex-lab / alyx-matlab

Some MATLAB functions for easier interfacing with an Alyx database

3 stars 2 forks source link

re-order the constructor so that dat.paths URL is used #50

Closed nsteinme closed 5 years ago

nsteinme commented 5 years ago

As it was previously, it will try to use cortexlab.net (the default) even if you have correctly specified a different URL in dat.paths, since the obj.login was coming before the URL stuff.

nsteinme commented 5 years ago

@k1o0 I can't tell what's going on with the tests? I guess the tests are not set up or working yet?

k1o0 commented 5 years ago

The tests are all set up and work pretty reliably except for the Alyx-related tests. For some reason 20% of the time the test database times out even on token requests, causing the tests to fail. I re-triggered the event and the tests passed.

jkbhagatio commented 5 years ago

@k1o0 do you want to add a simple test and merge this (or master) into dev too? Also regarding the changelog, how are you deciding on the version numbering for alyx-matlab and signals? I was thinking of starting them at 1.0.0 (only because there haven't been releases before, but besides this this is somewhat arbitrary) and creating releases.

jkbhagatio commented 5 years ago

Following up on this