search

cortex-lab / phy

phy: interactive visualization and manual spike sorting of large-scale ephys data
BSD 3-Clause "New" or "Revised" License
314 stars 157 forks source link

suggestion: freeze column labels on cluster and similarity view #1013

Closed nsteinme closed 4 years ago

nsteinme commented 4 years ago

Where "freeze" means like in excel, so that no matter where you scroll down on the list, you can still see the column headers. It could be an option, but I think ought to be the default.

rossant commented 4 years ago

I agree, I had tried to do that already and failed because of how the cluster view is currently implemented. This will probably require #951

czuba commented 4 years ago

I managed to get this header fix implemented in this submitted pull request.

The catch was a high-dpi scaling that was being used when setting up the clusterView window (transform & overflow) interfered with the HTML sticky header implementation. (...lots of google results about overflow being an issue, transformation issue was a brute force discovery)

Since the high-dpi scaling seemed to be producing other side-effects, axing them seemed like a worthwhile trade-off.

nsteinme commented 4 years ago

@rossant does this PR from czuba work? This issue is really painful - would be fantastic to have a solution merged.

rossant commented 4 years ago

the pull request has been merged -- sorry for the delay!