ClusterView filtering by group doesn't work

cortex-lab / phy

phy: interactive visualization and manual spike sorting of large-scale ephys data

BSD 3-Clause "New" or "Revised" License

311 stars 157 forks source link

ClusterView filtering by group doesn't work #1124

Open lshaheen opened 2 years ago

lshaheen commented 2 years ago

Hi,

I'm trying to filter by the cluster group like is mentioned here. Filtering by n_spikes, KSLabel, etc. all work, but for some reason filtering by group doesn't. If I type group == 'good' or group == "good" nothing happens. But if I type KSLabel == 'good' it works.

Thanks, Luke

czuba commented 2 years ago

ya, something seems fundamentally borked about the cluster group parameter in the ClusterView module recently.

Relatedly: Including 'group' column in the cluster view appears to break color-by-group styling in the cluster & similarity views. ...effectively a cluster's group can only be displayed as a text column OR cluster row coloring; but not both :-/