cortex-lab / phy

phy: interactive visualization and manual spike sorting of large-scale ephys data
BSD 3-Clause "New" or "Revised" License
304 stars 155 forks source link

Replace `np.in1d` which will be deprecated #1220

Closed zm711 closed 9 months ago

zm711 commented 9 months ago

@rossant

Just an FYI that np.in1d will be deprecated with the next version of NumPy and I assume will eventually be a hard error. This just updates calls to np.in1d to np.isin, which is the the NumPy standard. I also opened a PR in phylib to do the same.

I also scanned both repos for some other hard errors coming like float_ NaN and Inf which are aliases which will be dropped in the next version of NumPy (recs are to use float64 nan and inf, which both repos already use where necessary).