Change `np.in1d` into `np.isin` as `np.in1d` will be deprecated with new versions of NumPy

cortex-lab / phylib

Lightweight electrophysiological data analysis library

BSD 3-Clause "New" or "Revised" License

11 stars 23 forks source link

Change `np.in1d` into `np.isin` as `np.in1d` will be deprecated with new versions of NumPy #40

Closed zm711 closed 10 months ago

zm711 commented 1 year ago

This is just to try to future-proof phylib since within a few releases this could lead to a hard error. https://numpy.org/devdocs/release/2.0.0-notes.html Then if this is approved it would either need a new pypi release or switching the build instruction for phy.

JoeZiminski commented 10 months ago

Hey @zm711 do you know who best to ping for a review?

zm711 commented 10 months ago

@JoeZiminski , I don't. For the main phy repo @rossant has responded in the past, but I don't know who is managing phylib currently.

JoeZiminski commented 10 months ago

Thanks @zm711, Hi @rossant hope things are good. I saw you have moved into a new position / research field so appreciate you may not have time to review e.g. also #41. Let me know if there is someone else to contact, thanks for your time!

rossant commented 10 months ago

Thanks for the PR! LGTM, merging. cc @oliche @mayofaulkner