Clipboard countdown bug(s)

cortex / gopass

Gopass: A simple password-store GUI

GNU General Public License v3.0

188 stars 13 forks source link

Open lcmaqueda opened 7 years ago

lcmaqueda commented 7 years ago

The clipboard-clear countdown is started when selecting an entry, even if OS dialog for unlocking the key is canceled.
The clipboard countdown is not restarted if a new entry is selected.

lcmaqueda commented 7 years ago

There are also a couple of potential risks in the existing logic:

A potential race condition when checking if the counter was running
There is no limit in the number of gorutines that could be spawned to initialize the counter: holding the enter key over a password entry begins spawning goroutines without control that could result in a crash of the application or even the OS.