search

cortex / gopass

Gopass: A simple password-store GUI
GNU General Public License v3.0
190 stars 13 forks source link

Two "bug" fixes related to match() #30

Closed sandrogauci closed 5 years ago

sandrogauci commented 7 years ago

Please see the commit info.

lcmaqueda commented 7 years ago

I think gopass should be consistent with the way pass works. What's the behavior of pass about subdirs starting with dot? Does it index them?

sandrogauci commented 7 years ago

@cortex - I agree, it would be more neat to do the truncation on presentation.

@lcmaqueda - pass uses tree in cmd_find() which does not search through files or directories starting with a dot. My change only handles directories.

lcmaqueda commented 7 years ago

+1 to skipping directories starting with dot. I would even apply the same logic to regular files +1 to truncation on presentation. Otherwise we should trim the password-store prefix before matching to avoid matching the "/home/username/..."