search

cortex / ripasso

A simple password manager written in Rust
GNU General Public License v3.0
730 stars 64 forks source link

Relax requirement for 128 bit totp secrets #358

Closed Fingel closed 1 month ago

Fingel commented 1 month ago

totp-rs is strictly RFC6238 compliant. This is a good thing, but the reality is many sites/apps are still using 80 bit secrets for TOTP. These include Github, Discord, Paypal, among others. The author of totp-rs added a function from_url_unchecked to address this in this issue: https://github.com/constantoine/totp-rs/issues/46. I suggest we use it here so that ripasso can be used practically for totp.

alexanderkjall commented 1 month ago

This sounds like a good suggestion, thanks a lot for the pull request (both of them).

I will try to make time to review them later this week.