fix: nginx fails to forward requests to new pods

cortexproject / cortex-helm-chart

Helm chart for Cortex

Apache License 2.0

149 stars 164 forks source link

fix: nginx fails to forward requests to new pods #412

Closed TuTuRyYE closed 1 year ago

TuTuRyYE commented 2 years ago

Signed-off-by: ajaumet ajaumet@scaleway.com

What this PR does: This PR fixes NGINX not being able to reach newly created pods after deployment if NGINX is not reloaded in the process.

Which issue(s) this PR fixes: Fixes #

Checklist

[ x] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

nschad commented 2 years ago

Doesn't nginx re-resolve dns names, now? I believe we added this in #366. What you are doing is an "hack" so that nginx always re-resolves the dns name since the information is stored in variable, right?

Have you guys been running 1.6.0 and up?

TuTuRyYE commented 1 year ago

After some checks on our side, this seems to be resolved. I'm closing this PR.