search

cortexproject / cortex

A horizontally scalable, highly available, multi-tenant, long term Prometheus.
https://cortexmetrics.io/
Apache License 2.0
5.4k stars 782 forks source link

Add ability to drop cluster label after dedupe #1724

Closed tomwilkie closed 4 years ago

tomwilkie commented 4 years ago

A couple of users have asked for this; as we need a cluster label for deduping in the distributors, some people don't have this and adding it will break their graphs.

By "break their graphs", they will cause things like discontinuations in things like recording rules, which for LTS systems is undesirable.

@cstyan is this something we can make an option?

bboreham commented 4 years ago

we need a cluster label for deduping in the distributors

why is this?

cstyan commented 4 years ago

The cluster label is used to differentiate between HA Prometheus "pairs", the __replica__ label identifies each replica in the pair.

nbellowe commented 4 years ago

This is a similar ask to https://github.com/cortexproject/cortex/issues/1736

Any status updates?

cstyan commented 4 years ago

There's a PR open: https://github.com/cortexproject/cortex/pull/1726