search

cortexproject / cortex

A horizontally scalable, highly available, multi-tenant, long term Prometheus.
https://cortexmetrics.io/
Apache License 2.0
5.49k stars 802 forks source link

Lines shouldn't be able to go backwards... #244

Closed tomwilkie closed 7 years ago

tomwilkie commented 7 years ago
screen shot 2017-01-26 at 21 32 07
juliusv commented 7 years ago

I can't reproduce this, which is partially due to not being able to chose a time range in the current Cortex UI (cc @davkal). I first suspected this was due to not setting the linear interpolation option in Rickshaw (we had this problem in Prometheus once), but this option is set correctly: https://github.com/weaveworks/service-ui/blob/61516a01b2199b2f493bb9582b0515e1dd328542/client/src/pages/prom/graph/prom-graph-component.jsx#L137

tomwilkie commented 7 years ago

I have the exact repo still open, so I can get the results from the server.

Will do tomorrow.

On Mon, 30 Jan 2017 at 21:40, Julius Volz notifications@github.com wrote:

I can't reproduce this, which is partially due to not being able to chose a time range in the current Cortex UI (cc @davkal https://github.com/davkal). I first suspected this was due to not setting the linear interpolation option in Rickshaw (we had this problem in Prometheus once), but this option is set correctly: https://github.com/weaveworks/service-ui/blob/61516a01b2199b2f493bb9582b0515e1dd328542/client/src/pages/prom/graph/prom-graph-component.jsx#L137

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/weaveworks/cortex/issues/244#issuecomment-276199967, or mute the thread https://github.com/notifications/unsubscribe-auth/AAbGhYaIJbrzOINtcZkUXeUuJNkNEe-lks5rXli_gaJpZM4LvkIe .

davkal commented 7 years ago

Seen this again?

tomwilkie commented 7 years ago

Yes:

screen shot 2017-02-07 at 14 58 03

Here's the data https://gist.github.com/tomwilkie/609966c11878d1a84fc1787088962f6c

juliusv commented 7 years ago

I couldn't find any out-of-order samples in the dataset. So it seems to be some strange visual glitch which even happens when all samples are sorted correctly.

juliusv commented 7 years ago

@davkal fixed this in https://github.com/weaveworks/service-ui/commit/638485adcbb191f076e8bdab7d67693aa41252f7