Deprecate -distributor.shard-by-all-labels

cortexproject / cortex

A horizontally scalable, highly available, multi-tenant, long term Prometheus.

https://cortexmetrics.io/

Apache License 2.0

5.39k stars 784 forks source link

Open friedrichg opened 3 weeks ago

friedrichg commented 3 weeks ago

Describe the bug This option is disabled by default and produces imbalanced ingesters, which is never desirable.

Expected behavior The option should be enabled always and it should not be possible to disable it. We should remove the flag

Additional Context This should be easy to do, here is a similar PR https://github.com/cortexproject/cortex/pull/5816 Also remove the docs at https://cortexmetrics.io/docs/configuration/arguments/#distributor

tesla59 commented 3 weeks ago

Hi @friedrichg I would like to work on this issue. Can u please assign it to me?