cortinico / kotlin-android-template

Android + Kotlin + Github Actions + ktlint + Detekt + Gradle Kotlin DSL + buildSrc = โค๏ธ
MIT License
1.76k stars 241 forks source link

Introduce composeBom instead of version reference #205

Closed Grigoriym closed 9 months ago

Grigoriym commented 9 months ago

๐Ÿš€ Description

This PR aims to resolve this issue, to use composeBom rather than version reference

๐Ÿ“„ Motivation and Context

It resolves this issue

๐Ÿงช How Has This Been Tested?

I run the project on an emulator Pixel 7 Pro API 34 Project runs without problems. The only problem that is also seen on master is that min_sdk_version should be bumped because ui compose test fails. It can be fixed in a separate PR. Screenshot_2

Screenshot_1

๐Ÿ“ท Screenshots (if appropriate)

Already provided

๐Ÿ“ฆ Types of changes

โœ… Checklist

Grigoriym commented 9 months ago

@cortinico the pre-merge workflow for macos is failing. Maybe you know what is the issue?

cortinico commented 9 months ago

No idea, it was failing to resolve github.com when cloning. I've re-launched it

Grigoriym commented 9 months ago

Everything is good now, cool. Can be merged. Thanks

cortinico commented 9 months ago

Thanks for the contrib @Grigoriym ๐Ÿ™