search

cortinico / kotlin-android-template

Android + Kotlin + Github Actions + ktlint + Detekt + Gradle Kotlin DSL + buildSrc = ❤️
MIT License
1.73k stars 238 forks source link

Bump minSdk #206

Closed Grigoriym closed 8 months ago

Grigoriym commented 8 months ago

🚀 Description

While testing composeBom, it was noticed that compose ui test fails even on master. The problem is that minSdk is low

📄 Motivation and Context

It fixes the failed compose ui test

🧪 How Has This Been Tested?

The project builds and runs successfully. compose ui test runs successfully Screenshot_3

📷 Screenshots (if appropriate)

Provided

📦 Types of changes

✅ Checklist

cortinico commented 8 months ago

What's the reason why you bumped to 24 and not 23?

Grigoriym commented 8 months ago

What's the reason why you bumped to 24 and not 23?

I was thinking of 23, but I know that the new projects are created with the 24 minSdk version, and I decided to use it. But if you think it is not good, I can change to 23, np.

cortinico commented 8 months ago

Yup I'll try to stick to https://twitter.com/minsdkversion

So 23 is probably to be preferred here

Grigoriym commented 8 months ago

Updated to 23.